Skip to content

build: update dependency webpack-dev-server to v6 - #33735

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pr-takeover-33514
Aug 3, 2026
Merged

build: update dependency webpack-dev-server to v6#33735
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pr-takeover-33514

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

See associated pull request for more information.

Closes #33514 as a pr takeover

@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label Aug 3, 2026
@alan-agius4
alan-agius4 force-pushed the pr-takeover-33514 branch 2 times, most recently from 2095c1b to ac402d5 Compare August 3, 2026 10:22
See associated pull request for more information.

Closes angular#33514 as a pr takeover
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Aug 3, 2026
@alan-agius4
alan-agius4 requested a review from clydin August 3, 2026 11:33
@alan-agius4
alan-agius4 marked this pull request as ready for review August 3, 2026 11:33

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades webpack-dev-server to version 6.0.0 and updates the type references from WebpackDevServer.Configuration to Configuration. However, the upgrade introduces a critical runtime compatibility issue: webpack-dev-server v6 removes the callback-based startCallback and stopCallback methods. The code must be updated to use the Promise-based start() and stop() methods to support both v5 and v6 peer dependencies and prevent runtime crashes.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 3, 2026
@alan-agius4
alan-agius4 merged commit 5c8a055 into angular:main Aug 3, 2026
42 of 43 checks passed
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4
alan-agius4 deleted the pr-takeover-33514 branch August 3, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants